fix: correctly sort books with a half-star rating.#672
Merged
mateusz-bak merged 1 commit intomateusz-bak:masterfrom Jul 20, 2025
Merged
fix: correctly sort books with a half-star rating.#672mateusz-bak merged 1 commit intomateusz-bak:masterfrom
mateusz-bak merged 1 commit intomateusz-bak:masterfrom
Conversation
When sorting by rating, books with a rating of a half-star aren't sorted correctly. This was due to the ratings being converted to strings and those strings used for sorting. A half-star is stored as 5, which means that the string gets sorted as being above anything starting with 4 or less. I.e. anything but a full five stars. This has been fixed by doing the comparison on the int directly.
Contributor
Author
|
@mateusz-bak, the code style check failed. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sorting by rating, books with a rating of a half-star aren't sorted correctly.
This was due to the ratings being converted to strings and those strings used for sorting. A half-star is stored as 5, which means that the string gets sorted as being above anything starting with 4 or less. I.e. anything but a full five stars.
This has been fixed by doing the comparison on the int directly.